spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgaido91 <...@git.apache.org>
Subject [GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...
Date Wed, 19 Sep 2018 07:12:41 GMT
Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22450#discussion_r218690147
  
    --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/decimalArithmeticOperations.sql
---
    @@ -83,4 +83,7 @@ select 12345678912345678912345678912.1234567 + 9999999999999999999999999999999.1
     select 123456789123456789.1234567890 * 1.123456789123456789;
     select 12345678912345.123456789123 / 0.000000012345678;
     
    +-- division with negative scale operands
    +select 26393499451/ 1000e6;
    --- End diff --
    
    sure thanks. In 2.3 this truncates the output by some digits, ie. it would return `26.393499`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message