spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark issue #21677: [SPARK-24692][TESTS] Improvement FilterPushdownBenchmark
Date Fri, 14 Sep 2018 16:53:20 GMT
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/21677
  
    Me, too. I always used main-method style with the same reason. And many other BM are main-method
style. According to this PR description, the reasons seems to be
    1. There was a previous benchmark in that style; WideSchemaBenchmark
    2. The result is recorded in the text file outside the code.
    
    @wangyum . Do you want to add more?
    
    If there is no other reasons, I'll start to rollback this one and convert `WideSchemaBenchmark`
together in order to remove future confusions in dev community.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message