spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request #22400: [SPARK-25238][PYTHON] lint-python: Fix W605 warni...
Date Wed, 12 Sep 2018 17:07:02 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22400#discussion_r217100731
  
    --- Diff: dev/create-release/generate-contributors.py ---
    @@ -88,7 +88,7 @@ def print_indented(_list):
     
     
     def is_release(commit_title):
    -    return re.findall("\[release\]", commit_title.lower()) or \
    +    return re.findall(r"\[release\]", commit_title.lower()) or \
    --- End diff --
    
    Heh yeah not sure why it ended up as a regex, actually


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message