spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maropu <...@git.apache.org>
Subject [GitHub] spark pull request #22364: [SPARK-25379][SQL] Improve AttributeSet and Colum...
Date Mon, 10 Sep 2018 13:54:15 GMT
Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22364#discussion_r216329962
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/AttributeSet.scala
---
    @@ -39,10 +41,15 @@ object AttributeSet {
     
       /** Constructs a new [[AttributeSet]] given a sequence of [[Expression Expressions]].
*/
       def apply(baseSet: Iterable[Expression]): AttributeSet = {
    -    new AttributeSet(
    -      baseSet
    -        .flatMap(_.references)
    -        .map(new AttributeEquals(_)).toSet)
    --- End diff --
    
    The name is ok. We still need to use the mutable set instead of `new AttributeSet(sets.foldLeft(Set.empty[AttributeEquals])(_
++ _.baseSet))`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message