From reviews-return-692228-archive-asf-public=cust-asf.ponee.io@spark.apache.org Wed Aug 22 16:07:12 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B7291180662 for ; Wed, 22 Aug 2018 16:07:11 +0200 (CEST) Received: (qmail 19128 invoked by uid 500); 22 Aug 2018 14:07:10 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 19063 invoked by uid 99); 22 Aug 2018 14:07:10 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Aug 2018 14:07:10 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 2EEDEDFC4A; Wed, 22 Aug 2018 14:07:10 +0000 (UTC) From: mgaido91 To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #22141: [SPARK-25154][SQL] Support NOT IN sub-queries ins... Content-Type: text/plain Message-Id: <20180822140710.2EEDEDFC4A@git1-us-west.apache.org> Date: Wed, 22 Aug 2018 14:07:10 +0000 (UTC) Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22141#discussion_r211961738 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala --- @@ -137,13 +137,21 @@ object RewritePredicateSubquery extends Rule[LogicalPlan] with PredicateHelper { plan: LogicalPlan): (Option[Expression], LogicalPlan) = { var newPlan = plan val newExprs = exprs.map { e => - e transformUp { + e transformDown { --- End diff -- why did you change this? --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org