From reviews-return-687819-archive-asf-public=cust-asf.ponee.io@spark.apache.org Mon Aug 13 04:01:19 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B56C618061A for ; Mon, 13 Aug 2018 04:01:18 +0200 (CEST) Received: (qmail 63684 invoked by uid 500); 13 Aug 2018 02:01:17 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 63668 invoked by uid 99); 13 Aug 2018 02:01:17 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Aug 2018 02:01:17 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 12ED0E05E3; Mon, 13 Aug 2018 02:01:17 +0000 (UTC) From: ueshin To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #22075: [SPARK-23908][SQL][FOLLOW-UP] Rename inputs to ar... Content-Type: text/plain Message-Id: <20180813020117.12ED0E05E3@git1-us-west.apache.org> Date: Mon, 13 Aug 2018 02:01:17 +0000 (UTC) Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22075#discussion_r209478694 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -1852,6 +1852,11 @@ class DataFrameFunctionsSuite extends QueryTest with SharedSQLContext { df.selectExpr("transform(i, x -> x)") } assert(ex2.getMessage.contains("data type mismatch: argument 1 requires array type")) + + val ex3 = intercept[AnalysisException] { + df.selectExpr("transform(a, x -> x)") --- End diff -- The previous behavior was the same. I just added to check the behavior is as expected. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org