spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kiszk <...@git.apache.org>
Subject [GitHub] spark pull request #21912: [SPARK-24962][SQL] Refactor CodeGenerator.createU...
Date Fri, 31 Aug 2018 15:32:56 GMT
Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21912#discussion_r214392521
  
    --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
    @@ -463,23 +463,35 @@ public static UnsafeArrayData fromPrimitiveArray(
         final long[] data = new long[(int)totalSizeInLongs];
     
         Platform.putLong(data, Platform.LONG_ARRAY_OFFSET, length);
    -    if (arr != null) {
    --- End diff --
    
    Originally, this if is not here. It is fine with me to keep this for the safety.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message