spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arunmahadevan <...@git.apache.org>
Subject [GitHub] spark pull request #22251: [SPARK-25260][SQL] Fix namespace handling in Sche...
Date Tue, 28 Aug 2018 17:39:26 GMT
Github user arunmahadevan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22251#discussion_r213407441
  
    --- Diff: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala ---
    @@ -1099,6 +1098,27 @@ class AvroSuite extends QueryTest with SharedSQLContext with SQLTestUtils
{
         }
       }
     
    +  test("check namespace - toAvroType") {
    --- End diff --
    
    Its sort of covered in the below existing cases. Do you think we need more?
    
    [Validate namespace in avro file that has nested records with the same name](https://github.com/apache/spark/blob/master/external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala#L1078)
    [conversion to avro and back with namespace](https://github.com/apache/spark/blob/master/external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala#L510)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message