spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #22247: [SPARK-25253][PYSPARK] Refactor local connection ...
Date Tue, 28 Aug 2018 03:30:21 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22247#discussion_r213175296
  
    --- Diff: python/pyspark/worker.py ---
    @@ -364,8 +364,5 @@ def process():
         # Read information about how to connect back to the JVM from the environment.
         java_port = int(os.environ["PYTHON_WORKER_FACTORY_PORT"])
         auth_secret = os.environ["PYTHON_WORKER_FACTORY_SECRET"]
    -    sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
    -    sock.connect(("127.0.0.1", java_port))
    -    sock_file = sock.makefile("rwb", 65536)
    --- End diff --
    
    @vanzin, BTW, did you test this on Windows too?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message