spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgaido91 <...@git.apache.org>
Subject [GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...
Date Mon, 27 Aug 2018 15:13:26 GMT
Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22162#discussion_r213010672
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -815,6 +815,24 @@ class Dataset[T] private[sql](
         println(showString(numRows, truncate, vertical))
       // scalastyle:on println
     
    +  /**
    +   * Returns the default number of rows to show when the show function is called without
    +   * a user specified max number of rows.
    +   * @since 2.3.0
    +   */
    +  private def numberOfRowsToShow(): Int = {
    --- End diff --
    
    I'd remove the `()`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message