spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NiharS <...@git.apache.org>
Subject [GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API
Date Fri, 24 Aug 2018 23:57:24 GMT
Github user NiharS commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22192#discussion_r212778867
  
    --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java ---
    @@ -0,0 +1,104 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark;
    +
    +import org.apache.spark.api.java.JavaSparkContext;
    +
    +import org.junit.Assert;
    +import org.junit.Test;
    +
    +// Tests loading plugins into executors
    +public class ExecutorPluginSuite {
    +  // Static value modified by testing plugin to ensure plugin loaded correctly.
    +  public static int numSuccessfulPlugins = 0;
    +
    +  private SparkConf initializeSparkConf(String pluginNames) {
    +    return new SparkConf()
    +        .setMaster("local")
    +        .setAppName("test")
    +        .set("spark.executor.plugins", pluginNames);
    --- End diff --
    
    Sorry, could you explain this for me? Do you mean instead of `.set("spark.executor.plugins",
pluginNames)` I should a) have a variable storing the config name and b) pass the plugin names
to initializeSparkConf as a list, and have it as `.set(EXECUTOR_PLUGIN_CONF_NAME, String.join(",",
pluginNames)`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message