spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liyinan926 <...@git.apache.org>
Subject [GitHub] spark pull request #22146: [SPARK-24434][K8S] pod template files
Date Wed, 22 Aug 2018 19:01:01 GMT
Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22146#discussion_r212070807
  
    --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
---
    @@ -81,9 +97,9 @@ private[spark] class KubernetesDriverBuilder(
           .getOrElse(provideJavaStep(kubernetesConf))
     
         val allFeatures = (baseFeatures :+ bindingsStep) ++
    -      secretFeature ++ envSecretFeature ++ volumesFeature
    +      secretFeature ++ envSecretFeature ++ volumesFeature ++ templateVolumeFeature
    --- End diff --
    
    the `templateVolumeFeature` should be the first feature step so individual config properties
specified and handled by other steps may override the same config points in the template.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message