spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgaido91 <...@git.apache.org>
Subject [GitHub] spark pull request #22141: [SPARK-25154][SQL] Support NOT IN sub-queries ins...
Date Wed, 22 Aug 2018 14:07:10 GMT
Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22141#discussion_r211961738
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
    @@ -137,13 +137,21 @@ object RewritePredicateSubquery extends Rule[LogicalPlan] with PredicateHelper
{
           plan: LogicalPlan): (Option[Expression], LogicalPlan) = {
         var newPlan = plan
         val newExprs = exprs.map { e =>
    -      e transformUp {
    +      e transformDown {
    --- End diff --
    
    why did you change this?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message