spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BryanCutler <...@git.apache.org>
Subject [GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3
Date Tue, 21 Aug 2018 17:22:46 GMT
Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20838#discussion_r211688841
  
    --- Diff: python/pyspark/streaming/tests.py ---
    @@ -206,6 +207,38 @@ def func(dstream):
             expected = [[len(x)] for x in input]
             self._test_func(input, func, expected)
     
    +    def test_slice(self):
    +        """Basic operation test for DStream.slice."""
    +        import datetime as dt
    --- End diff --
    
    Also, not your doing but I noticed this spelling error on ln 183 "DStream.faltMap" should
be "DStream.flatMap", would you mind changing that while we are here?
    https://github.com/apache/spark/pull/20838/files#diff-ca4ec8dece48511b915cad6a801695c1R183


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message