spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rdblue <...@git.apache.org>
Subject [GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API
Date Tue, 07 Aug 2018 18:27:53 GMT
Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22009#discussion_r208337773
  
    --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/StreamingWriteSupportProvider.java
---
    @@ -29,24 +28,24 @@
      * provide data writing ability for structured streaming.
      */
     @InterfaceStability.Evolving
    -public interface StreamWriteSupport extends DataSourceV2, BaseStreamingSink {
    +public interface StreamingWriteSupportProvider extends DataSourceV2, BaseStreamingSink
{
     
    -    /**
    -     * Creates an optional {@link StreamWriter} to save the data to this data source.
Data
    -     * sources can return None if there is no writing needed to be done.
    -     *
    -     * @param queryId A unique string for the writing query. It's possible that there
are many
    -     *                writing queries running at the same time, and the returned
    -     *                {@link DataSourceWriter} can use this id to distinguish itself
from others.
    -     * @param schema the schema of the data to be written.
    -     * @param mode the output mode which determines what successive epoch output means
to this
    -     *             sink, please refer to {@link OutputMode} for more details.
    -     * @param options the options for the returned data source writer, which is an immutable
    -     *                case-insensitive string-to-string map.
    -     */
    -    StreamWriter createStreamWriter(
    -        String queryId,
    -        StructType schema,
    -        OutputMode mode,
    -        DataSourceOptions options);
    +  /**
    +   * Creates an optional {@link StreamingWriteSupport} to save the data to this data
source. Data
    --- End diff --
    
    This doesn't return `Optional`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message