spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <...@git.apache.org>
Subject [GitHub] spark pull request #22003: [SPARK-25019][BUILD] Fix orc dependency to use th...
Date Mon, 06 Aug 2018 17:01:55 GMT
Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22003#discussion_r207962501
  
    --- Diff: sql/core/pom.xml ---
    @@ -90,39 +90,11 @@
           <groupId>org.apache.orc</groupId>
           <artifactId>orc-core</artifactId>
           <classifier>${orc.classifier}</classifier>
    -      <exclusions>
    -        <exclusion>
    -          <groupId>org.apache.hadoop</groupId>
    -          <artifactId>hadoop-hdfs</artifactId>
    -        </exclusion>
    -        <!--
    -          orc-core:nohive doesn't have this dependency, but we adds this to prevent
    -          sbt from getting confused.
    -        -->
    -        <exclusion>
    -          <groupId>org.apache.hive</groupId>
    -          <artifactId>hive-storage-api</artifactId>
    -        </exclusion>
    -      </exclusions>
         </dependency>
         <dependency>
           <groupId>org.apache.orc</groupId>
           <artifactId>orc-mapreduce</artifactId>
           <classifier>${orc.classifier}</classifier>
    -      <exclusions>
    -        <exclusion>
    -          <groupId>org.apache.hadoop</groupId>
    -          <artifactId>hadoop-hdfs</artifactId>
    -        </exclusion>
    -        <!--
    -          orc-core:nohive doesn't have this dependency, but we adds this to prevent
    -          sbt from getting confused.
    -        -->
    -        <exclusion>
    -          <groupId>org.apache.hive</groupId>
    -          <artifactId>hive-storage-api</artifactId>
    -        </exclusion>
    -      </exclusions>
    --- End diff --
    
    Thank you. Just for me to understand it better. Do you know why defining exclusions in
this pom file messed up the pom?
    
    Also, how should I try it out myself? What is the right command to publish locally?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message