spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maropu <...@git.apache.org>
Subject [GitHub] spark pull request #21931: [SPARK-24978][SQL]Add spark.sql.fast.hash.aggrega...
Date Mon, 06 Aug 2018 07:58:28 GMT
Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21931#discussion_r207802603
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -1437,6 +1437,15 @@ object SQLConf {
         .intConf
         .createWithDefault(20)
     
    +  val FAST_HASH_AGGREGATE_MAX_ROWS_CAPACITY_BIT =
    +    buildConf("spark.sql.fast.hash.aggregate.row.max.capacity.bit")
    +      .internal()
    +      .doc("Capacity for the max number of rows to be held in memory by the fast hash
aggregate " +
    +        "product operator (e.g: configuration 16 capacity size is 65536).")
    +      .intConf
    +      .checkValue(bit => bit >= 1 && bit <= 30, "The bit value must
be in [1, 30].")
    --- End diff --
    
    We need to accept these small values, e.g., 2^1, 2^2, ..? I think these are meaningless...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message