spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jerryshao <...@git.apache.org>
Subject [GitHub] spark pull request #21895: [SPARK-24948][SHS] Delegate check access permissi...
Date Fri, 03 Aug 2018 01:25:26 GMT
Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21895#discussion_r207419217
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
---
    @@ -80,8 +80,8 @@ import org.apache.spark.util.kvstore._
      * break. Simple streaming of JSON-formatted events, as is implemented today, implicitly
      * maintains this invariant.
      */
    -private[history] class FsHistoryProvider(conf: SparkConf, clock: Clock)
    -  extends ApplicationHistoryProvider with Logging {
    +private[history] class FsHistoryProvider(conf: SparkConf, protected val clock: Clock)
    +  extends ApplicationHistoryProvider with LogFilesBlacklisting with Logging {
    --- End diff --
    
    This seems not so necessary, let's inline this trait.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message