spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maropu <...@git.apache.org>
Subject [GitHub] spark pull request #21608: [SPARK-24626] [SQL] Improve location size calcula...
Date Thu, 02 Aug 2018 00:50:21 GMT
Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21608#discussion_r207074028
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -1449,6 +1449,15 @@ object SQLConf {
         .intConf
         .checkValues((1 to 9).toSet + Deflater.DEFAULT_COMPRESSION)
         .createWithDefault(Deflater.DEFAULT_COMPRESSION)
    +
    +  val PARALLEL_FILE_LISTING_IN_COMMMANDS =
    +    buildConf("spark.sql.parallelFileListingInCommands.enabled")
    --- End diff --
    
    Currently, in the master, this listing happens only in the ANALYZE SQL command, so this
name fit the case now. But, in a future, if we probably add a new interface for the listing
(e.g., `SparkSession.analyzeTable`, `SparkSession.analyzeColumn`, ...), this name a little
confuses users? So, how about `spark.sql.parallelFileListingInStatsComputation.enabledl`?
@gatorsmile 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message