spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rdblue <...@git.apache.org>
Subject [GitHub] spark pull request #21921: [SPARK-24971][SQL] remove SupportsDeprecatedScanR...
Date Wed, 01 Aug 2018 15:58:05 GMT
Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21921#discussion_r206936422
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala
---
    @@ -416,12 +405,12 @@ class AdvancedDataSourceV2 extends DataSourceV2 with ReadSupport
{
           requiredSchema
         }
     
    -    override def planRowInputPartitions(): JList[InputPartition[Row]] = {
    -      val lowerBound = filters.collect {
    +    override def planInputPartitions(): JList[InputPartition[InternalRow]] = {
    +      val lowerBound = filters.collectFirst {
    --- End diff --
    
    Nit: this is an unrelated change.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message