spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HeartSaVioR <...@git.apache.org>
Subject [GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...
Date Wed, 01 Aug 2018 08:21:47 GMT
Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21733#discussion_r206788634
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StatefulOperatorsHelperSuite.scala
---
    @@ -0,0 +1,121 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.execution.streaming.state
    +
    +import org.apache.spark.sql.catalyst.expressions.{Attribute, SpecificInternalRow, UnsafeProjection,
UnsafeRow}
    +import org.apache.spark.sql.catalyst.expressions.codegen.GenerateUnsafeProjection
    +import org.apache.spark.sql.execution.streaming.StatefulOperatorsHelper.StreamingAggregationStateManager
    +import org.apache.spark.sql.streaming.StreamTest
    +import org.apache.spark.sql.types.{IntegerType, StructField, StructType}
    +
    +class StatefulOperatorsHelperSuite extends StreamTest {
    +  import TestMaterial._
    +
    +  test("StateManager v1 - get, put, iter") {
    +    val stateManager = newStateManager(KEYS_ATTRIBUTES, OUTPUT_ATTRIBUTES, 1)
    +
    +    // in V1, input row is stored as value
    +    testGetPutIterOnStateManager(stateManager, OUTPUT_ATTRIBUTES, TEST_ROW, TEST_KEY_ROW,
TEST_ROW)
    +  }
    +
    +  // ============================ StateManagerImplV2 ============================
    +  test("StateManager v2 - get, put, iter") {
    +    val stateManager = newStateManager(KEYS_ATTRIBUTES, OUTPUT_ATTRIBUTES, 2)
    +
    +    // in V2, row for values itself (excluding keys from input row) is stored as value
    +    // so that stored value doesn't have key part, but state manager V2 will provide
same output
    +    // as V1 when getting row for key
    +    testGetPutIterOnStateManager(stateManager, VALUES_ATTRIBUTES, TEST_ROW, TEST_KEY_ROW,
    +      TEST_VALUE_ROW)
    +  }
    +
    +  private def newStateManager(
    +      keysAttributes: Seq[Attribute],
    +      outputAttributes: Seq[Attribute],
    +      version: Int): StreamingAggregationStateManager = {
    +    StreamingAggregationStateManager.createStateManager(keysAttributes, outputAttributes,
version)
    +  }
    +
    +  private def testGetPutIterOnStateManager(
    +      stateManager: StreamingAggregationStateManager,
    +      expectedValueExpressions: Seq[Attribute],
    +      inputRow: UnsafeRow,
    +      expectedStateKey: UnsafeRow,
    +      expectedStateValue: UnsafeRow): Unit = {
    +
    +    assert(stateManager.getValueExpressions === expectedValueExpressions)
    +
    +    val memoryStateStore = new MemoryStateStore()
    +    stateManager.put(memoryStateStore, inputRow)
    +
    +    assert(memoryStateStore.iterator().size === 1)
    +
    +    val keyRow = stateManager.extractKey(inputRow)
    +    assert(keyRow === expectedStateKey)
    +
    +    // iterate state store and verify whether expected format of key and value are stored
    +    val pair = memoryStateStore.iterator().next()
    +    assert(pair.key === keyRow)
    +    assert(pair.value === expectedStateValue)
    +    assert(stateManager.restoreOriginRow(pair) === inputRow)
    +
    +    // verify the stored value once again via get
    +    assert(memoryStateStore.get(keyRow) === expectedStateValue)
    +
    +    // state manager should return row which is same as input row regardless of format
version
    +    assert(inputRow === stateManager.get(memoryStateStore, keyRow))
    +  }
    +
    +}
    +
    +object TestMaterial {
    +  val KEYS: Seq[String] = Seq("key1", "key2")
    --- End diff --
    
    I intended to use them like `static final` fields: so treated them as constants and follow
the style guide for constants - `Constants should be all uppercase letters and be put in a
companion object.` That's why I extracted them into separate object (though it is not a companion
object due to naming better) as well as naming as uppercases.
    
    But that is not intentional and definitely bad if it requires us to jump back and forth.
I'm going to place them as earliest part of class for now, but please let me know you are
seeing better place to put.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message