From reviews-return-677211-archive-asf-public=cust-asf.ponee.io@spark.apache.org Wed Jul 25 10:37:29 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5E1A018062C for ; Wed, 25 Jul 2018 10:37:29 +0200 (CEST) Received: (qmail 67662 invoked by uid 500); 25 Jul 2018 08:37:28 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 67651 invoked by uid 99); 25 Jul 2018 08:37:27 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jul 2018 08:37:27 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C0CAADFA5C; Wed, 25 Jul 2018 08:37:27 +0000 (UTC) From: HyukjinKwon To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #21650: [SPARK-24624][SQL][PYTHON] Support mixture of Pyt... Content-Type: text/plain Message-Id: <20180725083727.C0CAADFA5C@git1-us-west.apache.org> Date: Wed, 25 Jul 2018 08:37:27 +0000 (UTC) Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21650#discussion_r205025755 --- Diff: python/pyspark/sql/tests.py --- @@ -5487,6 +5617,22 @@ def dummy_pandas_udf(df): F.col('temp0.key') == F.col('temp1.key')) self.assertEquals(res.count(), 5) + def test_mixed_scalar_udfs_followed_by_grouby_apply(self): + # Test Pandas UDF and scalar Python UDF followed by groupby apply + from pyspark.sql.functions import udf, pandas_udf, PandasUDFType + import pandas as pd --- End diff -- not a big deal at all really .. but I would swap the import order (thridparty, pyspark) --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org