From reviews-return-675117-archive-asf-public=cust-asf.ponee.io@spark.apache.org Fri Jul 20 09:33:21 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D56A6180663 for ; Fri, 20 Jul 2018 09:33:20 +0200 (CEST) Received: (qmail 31663 invoked by uid 500); 20 Jul 2018 07:33:20 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 31652 invoked by uid 99); 20 Jul 2018 07:33:19 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Jul 2018 07:33:19 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 426ACDFAB3; Fri, 20 Jul 2018 07:33:19 +0000 (UTC) From: cloud-fan To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #21758: [SPARK-24795][CORE] Implement barrier execution m... Content-Type: text/plain Message-Id: <20180720073319.426ACDFAB3@git1-us-west.apache.org> Date: Fri, 20 Jul 2018 07:33:19 +0000 (UTC) Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21758#discussion_r203959637 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -274,7 +274,9 @@ private[spark] class TaskSchedulerImpl( maxLocality: TaskLocality, shuffledOffers: Seq[WorkerOffer], availableCpus: Array[Int], - tasks: IndexedSeq[ArrayBuffer[TaskDescription]]) : Boolean = { + tasks: IndexedSeq[ArrayBuffer[TaskDescription]], + addresses: ArrayBuffer[String], + taskDescs: ArrayBuffer[TaskDescription]) : Boolean = { --- End diff -- it's just cleaner. how about `addressesWithIndice` --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org