From reviews-return-672941-archive-asf-public=cust-asf.ponee.io@spark.apache.org Mon Jul 16 18:56:38 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C81B3180657 for ; Mon, 16 Jul 2018 18:56:37 +0200 (CEST) Received: (qmail 40387 invoked by uid 500); 16 Jul 2018 16:56:36 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 40365 invoked by uid 99); 16 Jul 2018 16:56:36 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Jul 2018 16:56:36 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 3674EDFFAC; Mon, 16 Jul 2018 16:56:36 +0000 (UTC) From: liyinan926 To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode. Content-Type: text/plain Message-Id: <20180716165636.3674EDFFAC@git1-us-west.apache.org> Date: Mon, 16 Jul 2018 16:56:36 +0000 (UTC) Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r202754518 --- Diff: docs/running-on-kubernetes.md --- @@ -529,8 +600,11 @@ specific to Spark on Kubernetes. spark.kubernetes.driver.pod.name (none) - Name of the driver pod. If not set, the driver pod name is set to "spark.app.name" suffixed by the current timestamp - to avoid name conflicts. + Name of the driver pod. In cluster mode, if this is not set, the driver pod name is set to "spark.app.name" + suffixed by the current timestamp to avoid name conflicts. In client mode, if your application is running + inside a pod, it is highly recommended to set this to the name of the pod your driver is running in. Setting this + value in client mode allows the driver to inform the cluster that your application's executor pods should be --- End diff -- Instead of saying `inform the cluster that your application's executor pods should be deleted ...`, it's better just say `to allows the driver pod to become the owner of your application's executor pods for garbage collection to work`. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org