spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From squito <...@git.apache.org>
Subject [GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...
Date Tue, 31 Jul 2018 21:58:29 GMT
Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20761#discussion_r206696107
  
    --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
---
    @@ -275,9 +287,13 @@ private[yarn] class YarnAllocator(
           s"executorsStarting: ${numExecutorsStarting.get}")
     
         if (missing > 0) {
    -      logInfo(s"Will request $missing executor container(s), each with " +
    -        s"${resource.getVirtualCores} core(s) and " +
    -        s"${resource.getMemory} MB memory (including $memoryOverhead MB of overhead)")
    +      var requestContainerMessage = s"Will request $missing executor container(s), each
with " +
    +          s"${resource.getVirtualCores} core(s) and " +
    +          s"${resource.getMemory} MB memory (including $memoryOverhead MB of overhead)"
    +      if (ResourceTypeHelper.isYarnResourceTypesAvailable()) {
    +        requestContainerMessage ++= s" with custom resources: " + resource.toString
    --- End diff --
    
    should this extra messages instead be conditioned on `executorResourceTypes.nonEmpty`?
 otherwise seems like it'll just repeat the memory & vcores from above in most cases.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message