spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #21822: [SPARK-24865] Remove AnalysisBarrier
Date Fri, 27 Jul 2018 05:53:54 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21822#discussion_r205674265
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
    @@ -787,6 +782,7 @@ class Analyzer(
               right
             case Some((oldRelation, newRelation)) =>
               val attributeRewrites = AttributeMap(oldRelation.output.zip(newRelation.output))
    +          // TODO(rxin): Why do we need transformUp here?
    --- End diff --
    
    we still need to transform resolved plan here to resolve self-join. Image
    ```
    val df = ...
    df.as("a").join(df.as("b"), ...)
    ```
    We need to look into the resolved plan to replace the conflicted attributes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message