spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #21758: [SPARK-24795][CORE] Implement barrier execution m...
Date Fri, 20 Jul 2018 07:33:19 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21758#discussion_r203959637
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
    @@ -274,7 +274,9 @@ private[spark] class TaskSchedulerImpl(
           maxLocality: TaskLocality,
           shuffledOffers: Seq[WorkerOffer],
           availableCpus: Array[Int],
    -      tasks: IndexedSeq[ArrayBuffer[TaskDescription]]) : Boolean = {
    +      tasks: IndexedSeq[ArrayBuffer[TaskDescription]],
    +      addresses: ArrayBuffer[String],
    +      taskDescs: ArrayBuffer[TaskDescription]) : Boolean = {
    --- End diff --
    
    it's just cleaner. how about `addressesWithIndice`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message