spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liyinan926 <...@git.apache.org>
Subject [GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.
Date Mon, 16 Jul 2018 16:56:36 GMT
Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21748#discussion_r202754518
  
    --- Diff: docs/running-on-kubernetes.md ---
    @@ -529,8 +600,11 @@ specific to Spark on Kubernetes.
       <td><code>spark.kubernetes.driver.pod.name</code></td>
       <td>(none)</td>
       <td>
    -    Name of the driver pod. If not set, the driver pod name is set to "spark.app.name"
suffixed by the current timestamp
    -    to avoid name conflicts.
    +    Name of the driver pod. In cluster mode, if this is not set, the driver pod name
is set to "spark.app.name"
    +    suffixed by the current timestamp to avoid name conflicts. In client mode, if your
application is running
    +    inside a pod, it is highly recommended to set this to the name of the pod your driver
is running in. Setting this
    +    value in client mode allows the driver to inform the cluster that your application's
executor pods should be
    --- End diff --
    
    Instead of saying `inform the cluster that your application's executor pods should be
deleted ...`, it's better just say `to allows the driver pod to become the owner of your application's
executor pods for garbage collection to work`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message