spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jiangxb1987 <...@git.apache.org>
Subject [GitHub] spark pull request #21729: [SPARK-24755][Core] Executor loss can cause task ...
Date Sun, 15 Jul 2018 15:03:26 GMT
Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21729#discussion_r202545576
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -87,7 +87,7 @@ private[spark] class TaskSetManager(
       // Set the coresponding index of Boolean var when the task killed by other attempt
tasks,
       // this happened while we set the `spark.speculation` to true. The task killed by others
       // should not resubmit while executor lost.
    -  private val killedByOtherAttempt: Array[Boolean] = new Array[Boolean](numTasks)
    +  private val killedByOtherAttempt = new HashSet[Long]
    --- End diff --
    
    @mridulm 's approach also sounds good to me.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message