spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #21667: [SPARK-24691][SQL]Dispatch the type support check...
Date Fri, 06 Jul 2018 11:08:02 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21667#discussion_r200621910
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala
---
    @@ -152,6 +152,11 @@ trait FileFormat {
         }
       }
     
    +  /**
    +   * Returns whether this format supports the given [[DataType]] in read/write path.
    +   * By default all data types are supported.
    +   */
    +  def supportDataType(dataType: DataType, isReadPath: Boolean): Boolean = true
    --- End diff --
    
    Technically this is an internal API but you keep the compatibility here in practice. I
think I already see we are concerned about Avro, right? I will doubt if it's a good idea to
expose this in this trait.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message