From reviews-return-666270-archive-asf-public=cust-asf.ponee.io@spark.apache.org Thu Jun 28 15:42:55 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 54A39180662 for ; Thu, 28 Jun 2018 15:42:55 +0200 (CEST) Received: (qmail 89621 invoked by uid 500); 28 Jun 2018 13:42:54 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 89610 invoked by uid 99); 28 Jun 2018 13:42:53 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Jun 2018 13:42:53 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 84F0EE0A42; Thu, 28 Jun 2018 13:42:53 +0000 (UTC) From: mgaido91 To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #21403: [SPARK-24341][SQL] Support only IN subqueries wit... Content-Type: text/plain Message-Id: <20180628134253.84F0EE0A42@git1-us-west.apache.org> Date: Thu, 28 Jun 2018 13:42:53 +0000 (UTC) Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21403#discussion_r198844447 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -161,33 +161,38 @@ case class Not(child: Expression) true """) // scalastyle:on line.size.limit -case class In(value: Expression, list: Seq[Expression]) extends Predicate { +case class In(values: Seq[Expression], list: Seq[Expression]) extends Predicate { --- End diff -- it is not a subquery, this is the "left part" of IN, so I don't really agree on `InSubquery`, but if you have another suggestion I am happy to follow it. Thanks. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org