spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request #21535: [SPARK-23596][SQL][WIP] Test interpreted path on ...
Date Tue, 12 Jun 2018 05:06:53 GMT
GitHub user viirya opened a pull request:

    https://github.com/apache/spark/pull/21535

    [SPARK-23596][SQL][WIP] Test interpreted path on Dataset and DataFrame test suites

    ## What changes were proposed in this pull request?
    
    We have completed a significant subset of the object related Expressions to provide an
interpreted fallback. This PR is going to modify the Dataset tests to also test the interpreted
code paths.
    
    One concern right now is that by testing the interpreted code paths too, we will double
current test time or more. Otherwise, we can only choose to test the interpreted code paths
for just few test suites such as DatasetSuite, DataFrameSuite.
    
    This is in WIP status now for discussing the approach and also the test scope of interpreted
code paths.
    
    ## How was this patch tested?
    
    Existing tests.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/viirya/spark-1 SPARK-23596

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21535.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21535
    
----
commit b8c7238aec9d6d79b8528eb3f47c0de7a48d23e8
Author: Liang-Chi Hsieh <viirya@...>
Date:   2018-06-12T05:00:06Z

    Test interpreted path on Dataset and DataFrame test suites.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message