spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From patrickmcgloin <...@git.apache.org>
Subject [GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...
Date Sat, 30 Jun 2018 19:13:37 GMT
Github user patrickmcgloin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21671#discussion_r199330156
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
    @@ -43,6 +43,11 @@ private[sql] class JacksonGenerator(
       // we can directly access data in `ArrayData` without the help of `SpecificMutableRow`.
       private type ValueWriter = (SpecializedGetters, Int) => Unit
     
    +  // A `ValueReader` is responsible for reading a field of an `InternalRow` to a String.
    +  // The only purpose of this is to read the key values for a map so that they can be
    +  // written as JSON filed names.
    --- End diff --
    
    Fixed


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message