spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gengliangwang <...@git.apache.org>
Subject [GitHub] spark pull request #21667: [SPARK-24691][SQL]Add new API `supportDataType` i...
Date Fri, 29 Jun 2018 07:56:54 GMT
Github user gengliangwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21667#discussion_r199081671
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala
---
    @@ -156,28 +156,6 @@ class HiveOrcSourceSuite extends OrcSuite with TestHiveSingleton
{
             sql("select testType()").write.mode("overwrite").orc(orcDir)
           }.getMessage
           assert(msg.contains("ORC data source does not support calendarinterval data type."))
    -
    -      // read path
    --- End diff --
    
    @HyukjinKwon No, the unit test is about unsupported data types, and ORC supports all data
types in read path.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message