spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rdblue <...@git.apache.org>
Subject [GitHub] spark pull request #21556: [SPARK-24549][SQL] Support Decimal type push down...
Date Thu, 28 Jun 2018 16:31:28 GMT
Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21556#discussion_r198906232
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
    @@ -359,6 +369,70 @@ class ParquetFilterSuite extends QueryTest with ParquetTest with
SharedSQLContex
         }
       }
     
    +  test("filter pushdown - decimal") {
    +    Seq(true, false).foreach { legacyFormat =>
    +      withSQLConf(SQLConf.PARQUET_WRITE_LEGACY_FORMAT.key -> legacyFormat.toString)
{
    +        Seq(s"_1 decimal(${Decimal.MAX_INT_DIGITS}, 2)", // 32BitDecimalType
    --- End diff --
    
    Since this is providing a column name, it would be better to use something more readable
than _1.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message