spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgaido91 <...@git.apache.org>
Subject [GitHub] spark pull request #21403: [SPARK-24341][SQL] Support only IN subqueries wit...
Date Thu, 28 Jun 2018 13:42:53 GMT
Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21403#discussion_r198844447
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
    @@ -161,33 +161,38 @@ case class Not(child: Expression)
            true
       """)
     // scalastyle:on line.size.limit
    -case class In(value: Expression, list: Seq[Expression]) extends Predicate {
    +case class In(values: Seq[Expression], list: Seq[Expression]) extends Predicate {
    --- End diff --
    
    it is not a subquery, this is the "left part" of IN, so I don't really agree on `InSubquery`,
but if you have another suggestion I am happy to follow it. Thanks.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message