spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #21596: [SPARK-24601] Bump Jackson version
Date Thu, 28 Jun 2018 01:35:35 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21596#discussion_r198686913
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonBenchmarks.scala
---
    @@ -25,8 +25,13 @@ import org.apache.spark.util.{Benchmark, Utils}
     
     /**
      * The benchmarks aims to measure performance of JSON parsing when encoding is set and
isn't.
    - * To run this:
    - *  spark-submit --class <this class> --jars <spark sql test jar>
    + * To run:
    + *  mvn clean package -pl sql/core -DskipTests
    + *  ./dev/make-distribution.sh --name local-dist
    + *  cd dist/
    + *  ./bin/spark-submit --class org.apache.spark.sql.execution.datasources.json.JSONBenchmarks
\
    + *      ../sql/core/target/spark-sql_2.11-2.4.0-SNAPSHOT-tests.jar > /tmp/output.txt
    --- End diff --
    
    Let's take out other comments like `make-distribution.sh` and `cd dist/` too since they
can be varied by how to build.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message