spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgaido91 <...@git.apache.org>
Subject [GitHub] spark pull request #21619: [SPARK-24635][SQL] Remove Blocks class from JavaC...
Date Sat, 23 Jun 2018 13:05:50 GMT
Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21619#discussion_r197611318
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
    @@ -148,14 +149,17 @@ trait Block extends JavaCode {
       }
     
       // Concatenates this block with other block.
    -  def + (other: Block): Block
    +  def + (other: Block): Block = other match {
    +    case EmptyBlock => this
    +    case _ => code"$this\n$other"
    --- End diff --
    
    why do we need `\n` here? It may be a single space as well in many cases or even nothing,
IIUC


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message