spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rdblue <...@git.apache.org>
Subject [GitHub] spark pull request #21606: [SPARK-24552][core][SQL] Use task ID instead of a...
Date Fri, 22 Jun 2018 19:11:51 GMT
Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21606#discussion_r197542830
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
    @@ -125,11 +124,11 @@ object DataWritingSparkTask extends Logging {
             val coordinator = SparkEnv.get.outputCommitCoordinator
             val commitAuthorized = coordinator.canCommit(stageId, stageAttempt, partId, attemptId)
             if (commitAuthorized) {
    -          logInfo(s"Writer for stage $stageId / $stageAttempt, " +
    +          logInfo(s"Writer for stage $stageId.$stageAttempt, " +
                 s"task $partId.$attemptId is authorized to commit.")
               dataWriter.commit()
             } else {
    -          val message = s"Stage $stageId / $stageAttempt, " +
    +          val message = s"Stage $stageId.$stageAttempt, " +
    --- End diff --
    
    (This is for the next line, sorry for the confusion)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message