spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maropu <...@git.apache.org>
Subject [GitHub] spark pull request #21568: [SPARK-24562][TESTS] Support different configs fo...
Date Sat, 16 Jun 2018 03:54:36 GMT
Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21568#discussion_r195892983
  
    --- Diff: sql/core/src/test/resources/sql-tests/results/typeCoercion/native/decimalArithmeticOperations.sql_spark.sql.decimalOperations.allowPrecisionLoss-false.out
---
    @@ -0,0 +1,193 @@
    +-- Automatically generated by SQLQueryTestSuite
    --- End diff --
    
    This new feature pretty looks to me. Btw, if we set multiple configurations, filenames
get too long? How about adding the configuration info. in the head of files?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message