spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kiszk <...@git.apache.org>
Subject [GitHub] spark pull request #21570: [SPARK-24564][TEST] Add test suite for RecordBina...
Date Fri, 15 Jun 2018 06:08:35 GMT
Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21570#discussion_r195640246
  
    --- Diff: sql/core/src/test/java/test/org/apache/spark/sql/execution/sort/RecordBinaryComparatorSuite.java
---
    @@ -0,0 +1,255 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package test.org.apache.spark.sql.execution.sort;
    +
    +import org.apache.spark.SparkConf;
    +import org.apache.spark.memory.TaskMemoryManager;
    +import org.apache.spark.memory.TestMemoryConsumer;
    +import org.apache.spark.memory.TestMemoryManager;
    +import org.apache.spark.sql.catalyst.expressions.UnsafeArrayData;
    +import org.apache.spark.sql.catalyst.expressions.UnsafeRow;
    +import org.apache.spark.sql.execution.RecordBinaryComparator;
    +import org.apache.spark.unsafe.Platform;
    +import org.apache.spark.unsafe.UnsafeAlignedOffset;
    +import org.apache.spark.unsafe.array.LongArray;
    +import org.apache.spark.unsafe.memory.MemoryBlock;
    +import org.apache.spark.unsafe.types.UTF8String;
    +import org.apache.spark.util.collection.unsafe.sort.*;
    +import org.junit.After;
    --- End diff --
    
    nit: is it better to insert a line?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message