spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From witgo <...@git.apache.org>
Subject [GitHub] spark pull request #21346: [SPARK-6237][NETWORK] Network-layer changes to al...
Date Fri, 15 Jun 2018 00:48:45 GMT
Github user witgo commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21346#discussion_r195287202
  
    --- Diff: common/network-common/src/main/java/org/apache/spark/network/protocol/UploadStream.java
---
    @@ -0,0 +1,107 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.network.protocol;
    +
    +import java.io.IOException;
    +import java.nio.ByteBuffer;
    +
    +import com.google.common.base.Objects;
    +import io.netty.buffer.ByteBuf;
    +
    +import org.apache.spark.network.buffer.ManagedBuffer;
    +import org.apache.spark.network.buffer.NettyManagedBuffer;
    +
    +/**
    + * An RPC with data that is sent outside of the frame, so it can be read as a stream.
    + */
    +public final class UploadStream extends AbstractMessage implements RequestMessage {
    --- End diff --
    
    Is it possible to merge UploadStream and RpcRequest into a class?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message