spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From squito <...@git.apache.org>
Subject [GitHub] spark pull request #21068: [SPARK-16630][YARN] Blacklist a node if executors...
Date Thu, 14 Jun 2018 20:49:36 GMT
Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21068#discussion_r195566345
  
    --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocatorBlacklistTracker.scala
---
    @@ -151,9 +149,9 @@ private[spark] class FailureTracker(
       private def updateAndCountFailures(failedExecutorsWithTimeStamps: mutable.Queue[Long]):
Int = {
         val endTime = clock.getTimeMillis()
         while (executorFailuresValidityInterval > 0 &&
    -      failedExecutorsWithTimeStamps.nonEmpty &&
    -      failedExecutorsWithTimeStamps.head < endTime - executorFailuresValidityInterval)
{
    -      failedExecutorsWithTimeStamps.dequeue()
    +        failedExecutorsWithTimeStamps.nonEmpty &&
    +        failedExecutorsWithTimeStamps.head < endTime - executorFailuresValidityInterval)
{
    +        failedExecutorsWithTimeStamps.dequeue()
    --- End diff --
    
    but only single indent the body of the `while`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message