spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferH...
Date Mon, 11 Jun 2018 19:52:33 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20636#discussion_r194526656
  
    --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
    @@ -61,6 +61,10 @@
        * Grows the buffer by at least neededSize and points the row to the buffer.
        */
       void grow(int neededSize) {
    +    if (neededSize < 0) {
    --- End diff --
    
    I think we can use `assert` here. When `neededSize` is negative, there must be an overflow.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message