spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mgaido91 <...@git.apache.org>
Subject [GitHub] spark issue #21520: [SPARK-24505][SQL] Forbidding string interpolation in Co...
Date Sun, 10 Jun 2018 14:39:54 GMT
Github user mgaido91 commented on the issue:

    https://github.com/apache/spark/pull/21520
  
    yes, this is a great work @viirya ! It would be great if we can split it into smaller
updates. What do you think about starting doing the needed changes in smaller PRs which focus
only on specific part and forbidding the string interpolation after those have made the needed
changes smaller?
    
    I also like and agree with @kiszk about introducing new APIs. In particular, in the last
days I checked the part related to the usage of `freshName `. IMO, we can introduce a new
method `addLocalVariable` (and maybe renaming `addMutableState` to `addGlobalVariable`) and
make `freshName` private (or if it not feasible as we are using it also for methods' names
we can restrict its usage only to that particular case). What do you think?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message