From reviews-return-652658-archive-asf-public=cust-asf.ponee.io@spark.apache.org Fri May 25 01:15:00 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7CE36180636 for ; Fri, 25 May 2018 01:14:59 +0200 (CEST) Received: (qmail 15510 invoked by uid 500); 24 May 2018 23:14:58 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 15497 invoked by uid 99); 24 May 2018 23:14:57 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 May 2018 23:14:57 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 6877DE0B37; Thu, 24 May 2018 23:14:57 +0000 (UTC) From: erikerlandson To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #21366: [SPARK-24248][K8S][WIP] Use the Kubernetes API to... Content-Type: text/plain Message-Id: <20180524231457.6877DE0B37@git1-us-west.apache.org> Date: Thu, 24 May 2018 23:14:57 +0000 (UTC) Github user erikerlandson commented on a diff in the pull request: https://github.com/apache/spark/pull/21366#discussion_r190755750 --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/DeterministicExecutorPodsEventQueue.scala --- @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.scheduler.cluster.k8s + +import io.fabric8.kubernetes.api.model.Pod +import scala.collection.mutable + +class DeterministicExecutorPodsEventQueue extends ExecutorPodsEventQueue { + + private val eventBuffer = mutable.Buffer.empty[Pod] + private val subscribers = mutable.Buffer.empty[(Seq[Pod]) => Unit] + + override def addSubscriber + (processBatchIntervalMillis: Long) + (onNextBatch: (Seq[Pod]) => Unit): Unit = { + subscribers += onNextBatch + } + + override def stopProcessingEvents(): Unit = {} + + override def pushPodUpdate(updatedPod: Pod): Unit = eventBuffer += updatedPod --- End diff -- So events are pods themselves, as opposed to some event structure on pods? --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org