From reviews-return-647102-archive-asf-public=cust-asf.ponee.io@spark.apache.org Mon May 14 08:28:52 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5C2FC180627 for ; Mon, 14 May 2018 08:28:52 +0200 (CEST) Received: (qmail 68883 invoked by uid 500); 14 May 2018 06:28:51 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 68861 invoked by uid 99); 14 May 2018 06:28:49 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 May 2018 06:28:49 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id B7D09E96AE; Mon, 14 May 2018 06:28:49 +0000 (UTC) From: BryanCutler To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark issue #21312: [SPARK-24259][SQL] ArrayWriter for Arrow produces wrong ... Content-Type: text/plain Message-Id: <20180514062849.B7D09E96AE@git1-us-west.apache.org> Date: Mon, 14 May 2018 06:28:49 +0000 (UTC) Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/21312 Thanks for catching this @viirya! Looks good from a first glance, but my only concern is that `clear()` will release the vector buffers, where `reset()` just zeros them out. Let me look into that a little further tomorrow and make sure it won't cause a problem. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org