From reviews-return-645119-archive-asf-public=cust-asf.ponee.io@spark.apache.org Tue May 8 18:09:29 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0001918063B for ; Tue, 8 May 2018 18:09:28 +0200 (CEST) Received: (qmail 76398 invoked by uid 500); 8 May 2018 16:09:28 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 76382 invoked by uid 99); 8 May 2018 16:09:27 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 May 2018 16:09:27 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 67DA2E0614; Tue, 8 May 2018 16:09:27 +0000 (UTC) From: dongjoon-hyun To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #21266: [SPARK-24206][SQL] Improve DataSource read benchm... Content-Type: text/plain Message-Id: <20180508160927.67DA2E0614@git1-us-west.apache.org> Date: Tue, 8 May 2018 16:09:27 +0000 (UTC) Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/21266#discussion_r186782874 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadBenchmark.scala --- @@ -1,339 +0,0 @@ -/* --- End diff -- @maropu . Since you are merging ParquetReadBenchmark and OrcReadBenchmark benchmarks, let's remove [OrcReadBenchmark](https://github.com/apache/spark/blob/master/sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala). --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org