From reviews-return-644982-archive-asf-public=cust-asf.ponee.io@spark.apache.org Tue May 8 09:33:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7A2FB180674 for ; Tue, 8 May 2018 09:33:04 +0200 (CEST) Received: (qmail 63957 invoked by uid 500); 8 May 2018 07:33:03 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 63931 invoked by uid 99); 8 May 2018 07:33:02 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 May 2018 07:33:02 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C9757E09F4; Tue, 8 May 2018 07:33:02 +0000 (UTC) From: jerryshao To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #21243: [SPARK-24182][yarn] Improve error message when cl... Content-Type: text/plain Message-Id: <20180508073302.C9757E09F4@git1-us-west.apache.org> Date: Tue, 8 May 2018 07:33:02 +0000 (UTC) Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/21243#discussion_r186639699 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -346,7 +346,7 @@ private[spark] class ApplicationMaster(args: ApplicationMasterArguments) extends synchronized { if (!finished) { val inShutdown = ShutdownHookManager.inShutdown() - if (registered) { + if (registered || !isClusterMode) { --- End diff -- Why would we need to add non-cluster mode check here? --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org