spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liyinan926 <...@git.apache.org>
Subject [GitHub] spark pull request #21366: [SPARK-24248][K8S] Use the Kubernetes API to popu...
Date Fri, 25 May 2018 17:56:43 GMT
Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21366#discussion_r190967916
  
    --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingEventSource.scala
---
    @@ -0,0 +1,65 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.scheduler.cluster.k8s
    +
    +import java.util.concurrent.{Future, ScheduledExecutorService, TimeUnit}
    +
    +import io.fabric8.kubernetes.client.KubernetesClient
    +import scala.collection.JavaConverters._
    +
    +import org.apache.spark.SparkConf
    +import org.apache.spark.deploy.k8s.Config._
    +import org.apache.spark.deploy.k8s.Constants._
    +
    +private[spark] class ExecutorPodsPollingEventSource(
    +    conf: SparkConf,
    +    kubernetesClient: KubernetesClient,
    +    eventQueue: ExecutorPodsEventQueue,
    +    pollingExecutor: ScheduledExecutorService) {
    +
    +  private val pollingInterval = conf.get(KUBERNETES_EXECUTOR_API_POLLING_INTERVAL)
    +
    +  private var pollingFuture: Future[_] = _
    +
    +  def start(applicationId: String): Unit = {
    +    require(pollingFuture == null, "Cannot start polling more than once.")
    +    pollingFuture = pollingExecutor.scheduleWithFixedDelay(
    +      new PollRunnable(applicationId), pollingInterval, pollingInterval, TimeUnit.MILLISECONDS)
    +  }
    +
    +  def stop(): Unit = {
    +    if (pollingFuture != null) {
    +      pollingFuture.cancel(true)
    +      pollingFuture = null
    +    }
    +    pollingExecutor.shutdown()
    --- End diff --
    
    Oops. Yes, that's true. Let's have a utility method and do the following in the method:
    
    ```
    executor.shutdown()
    executor.waitForTermination(30, TimeUnit.SECONDS)
    if (!executor.isShutdown()) {
        executor.shutdownNow()
    }
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message